Move server service level objectives to servers.json#1223
Merged
balajikris merged 2 commits intoAzure:masterfrom May 15, 2017
Merged
Move server service level objectives to servers.json#1223balajikris merged 2 commits intoAzure:masterfrom
balajikris merged 2 commits intoAzure:masterfrom
Conversation
Contributor
|
Hey @nathannfan - so all commits to this PR are purely moving stuff from one spec to another? No other additions/deletions expected? |
Contributor
Author
|
@balajikris yep, just doing this to rework the categories we're generating in docs.microsoft.com. I did have to copy SubResource to servers.json as a dependency, but nothing new. |
balajikris
approved these changes
May 15, 2017
Contributor
|
For existing warns/errors, there is a open workitem that we're tracking. This PR doesn't create any new violations. I've reviewed the changes and I'm okay with it. Merging in as is. |
Contributor
Author
|
Thanks, @balajikris! |
|
No modification for NodeJS |
mccleanp
pushed a commit
that referenced
this pull request
Mar 23, 2022
Co-authored-by: Jeremy Lautman <jelautma@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger
This change is